Conversation
platypii
approved these changes
Nov 25, 2025
Contributor
platypii
left a comment
platypii
left a comment
There was a problem hiding this comment.
I don't love the negative 50% transform it feels hacky. But I pulled the branch, and tried using flexbox and stuff and couldn't find any better solution (nothing else worked). So 👍
severo
approved these changes
Nov 25, 2025
Contributor
severo
left a comment
severo
left a comment
There was a problem hiding this comment.
OK, cool improvement.
Note also that an alternative is to override the CSS in the client app. We don't necessarily need to take all the use cases into account in the base styles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the styles looking ok no matter how tall the headers are. Vertically center the sort icon instead of giving it a fixed margin.